Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the py test fixture more robust #109

Closed
wants to merge 3 commits into from
Closed

Make the py test fixture more robust #109

wants to merge 3 commits into from

Conversation

clint-lawrence
Copy link

The tests fail for me when running with a fresh clone using doit with python 3.8 on os x.

Depending on how the test virtual environment is created, there is not always a symlink with the python. naming convention. python -m venv creates only python & python3. Using virtualenv to manually create a virtual environment creates python3.8 symlink and the tests run fine.

This fix modifies the py test fixture so that it creates its own symlink in a temp directory. Then uses that temp directory as the modified PATH passed to the py launcher environment when the test runs.

@clint-lawrence
Copy link
Author

This really only effects development. And I see now that more recent version of venv create the pythonx.y symlink, so this is probably not worth complicating the tests for.

@brettcannon
Copy link
Owner

Since you already pointed out that newer versions of Python don't have this issue I'm going to close this to keep things simple. Thanks for investigating, though!

@brettcannon brettcannon closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants