-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyenv FAQ env var commands #144
Conversation
When using pyenv and global not set (defaulting to system) or global set to `system` the Launcher was unable to determine correct version to use. Fixed by using `pyenv exec` to correctly determine current Python version instead of parsing pyenv config files. Fixes brettcannon#141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tricky thing with this compared to the old solution is PY_PYTHON
is the default version to use when no specific major version is requested, e.g. it's not the same as PY_PYTHON2
. That means this isn't technically right as you have to make an assumption as to what major version of Python people want to depend on compared to the solution of reading (pyenv root)/version
).
Maybe it's better to list both solutions?
2227f5f
to
72af0a0
Compare
I merged your suggestions but then changed my mind and reverted as I think there has been a misunderstanding.
The use of I hope this make sense? |
Then please drop the |
Co-authored-by: Brett Cannon <brett@python.org>
I agree, was including it for completeness for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized the changes were made against the main copy of the README and not the template which the README is generated from. Would you mind applying the changes to https://github.com/brettcannon/python-launcher/blob/main/docs/readme/template.md instead?
Thanks for the help with this! |
When using pyenv and global not set (defaulting to system) or global set to
system
the Launcher was unable to determine correct version to use.Fixed by using
pyenv exec
to correctly determine current Python version instead of parsing pyenv config files.Fixes #141