Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installerscript for audiobookshelf #15

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

Sh4dowNight
Copy link
Contributor

Installerscript for audiobookshelf

Installerscript for audiobookshelf
@brettpetch
Copy link
Owner

brettpetch commented Sep 18, 2023

Happy with this other than the one change needed. Nice work.

@Sh4dowNight
Copy link
Contributor Author

Happy with this other than the one change needed. Nice work.

Thank you sir.

What change do you mean in particular?

Maybe it would be useful not to hardcode the version and implement a logic that always installs the latest version.

Besides that feel free to change whatever you desire.

@brettpetch
Copy link
Owner

echo 'This is unsupported software. You will not get help with this, please answer `yes` if you understand and wish to proceed'
if [[ -z ${eula} ]]; then
    read -r eula
fi

if ! [[ $eula =~ yes ]]; then
  echo "You did not accept the above. Exiting..."
  exit 1
else
  echo "Proceeding with installation"
fi

Eula confirmation added
Changed line break type from CR+LF to LF (UNIX)
@Sh4dowNight
Copy link
Contributor Author

Done!

@brettpetch
Copy link
Owner

brettpetch commented Sep 19, 2023

Going to run this through shellcheck when I get home and ensure that everything is in order, then will squash and merge. Not sure how I feel about binaries existing in $HOME/.config/appname, I think a more appropriate place would be $HOME/.local/bin.

@redoXiD
Copy link
Contributor

redoXiD commented Sep 19, 2023

I already tested the script on my box, but somehow audiobookshelf does not start. When I run the executable directly, I get this error message:
image
Unfortunately, we were not able to reproduce the error yet (tested it on @Sh4dowNight's hbd boxes, hbd boxes of a few other users and a VPS), so further testing would be needed to identify the range of the problem. (it could be a different server configuration as I'm on a different server than the other boxes we tested.)
Edit: at least one other server is confirmed to have these problems.
However, audiobookshelf versions up to 2.2.23 are working, the problem started with v2.3.0.

I also found a bug report where the same error occured on QNAP NAS devices. In an unpacked working qpkg file (v2.3.3) I discovered that the developer (of the QNAP installer) maybe has solved the problem by copying a node_sqlite3.node file to the installation directory, but I was not able try the fix as as this script runs the binary directly.

@brettpetch
Copy link
Owner

To me it sounds like sqlite isn't being compiled correctly, maybe a python issue?

@Sh4dowNight
Copy link
Contributor Author

I just added the fix for audiobookshelf, it is confirmed to work on at least 4 different appboxes. @brettpetch

@brettpetch brettpetch merged commit 8a3ea94 into brettpetch:master Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants