Add undef protection to categorize #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brh55
reviewed
May 10, 2021
|
Sounds good to me!
…On Mon, May 10, 2021 at 10:52 AM Brandon Him ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In middleware/categorize.js
<#21 (comment)>:
> @@ -18,11 +18,13 @@ const categorize = (bot, message) => {
message.type = 'direct_message';
}
- if (isMention(botId, message.text)) {
- message.type = 'mention';
+ if (message.text !== undefined) {
+ if (isMention(botId, message.text)) {
Good catch, perhaps we can just merge it in one conditional if
(mesage.text !== undefined && isMention(botId, message.text) to keep the
nesting minimal.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAO6G57RYWG2SFYY2EPHQDTNAMM7ANCNFSM44P4PMHQ>
.
|
joemcmahon
force-pushed
the
fix-ismention-potential-exception
branch
from
3f6de4e
to
f0a115f
Compare
|
Simplified version: I set |
In some cases, messages arrive with message.text set to undefined. This causes the iSMention check in categorize.js to fail and causes CoreBot.js to throw a "An error occurred in the categorize middleware: TypeError: Cannot read property 'indexOf' of undefined" error. Set the text to "" to allow the checks to occur (and fail) but not throw an exception.
joemcmahon
force-pushed
the
fix-ismention-potential-exception
branch
from
f0a115f
to
c35bdc9
Compare
|
Aaaand of course I reversed the sense of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, messages arrive with message.text set to undefined. This
causes the iSMention check in categorize.js to fail and causes
CoreBot.js to throw a "An error occurred in the categorize middleware:
TypeError: Cannot read property 'indexOf' of undefined" error.
Add a check for the message text being undefined so we skip the mention
and direct_mention checks (they can't pass anyway if the message is
undefined).