Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with "Full Flash Unlocked (BIN/FRF)" #57

Closed
ButcherDSM opened this issue Jun 24, 2022 · 13 comments
Closed

issue with "Full Flash Unlocked (BIN/FRF)" #57

ButcherDSM opened this issue Jun 24, 2022 · 13 comments

Comments

@ButcherDSM
Copy link

Hello

after successful unlock, on level Full Flash Unlocked (BIN/FRF) - nothing happens and in logs i see some errors
Flash Stock (Re-Lock) also not work and car dont start now (

please help me, thanks!

all files in attac
simos 18_1.zip
h

@sagishm
Copy link

sagishm commented Jun 24, 2022

Your ecu is locked and immo not passed, you need to read ecu in boot and so immo off, then you need to write original frf.

@ButcherDSM
Copy link
Author

so, my friend with Magic Flex make "restore to original" and car alive.
i cant use your VW_Flash for my car?

@sagishm
Copy link

sagishm commented Jun 24, 2022

You can, follow the instructions step by step.

@ButcherDSM
Copy link
Author

i follow instructions step by step and got error
i do something wrong?

@ButcherDSM
Copy link
Author

tell me please, what am I doing wrong?

i take file FRF that full identicaly to my ID.

then at the stage from documentation:

Flashing your new software.
Pick "Open Folder..." and navigate to your Tune folder.
Pick "Full Flash Unlocked (BIN/FRF)".
Pick the FL_XX_XX.bin file matching your car

VW_flash starts unpacking something and stops at 80 with an error in the log window

@sagishm
Copy link

sagishm commented Jun 24, 2022

You selected the wrong unlock, you needs to select “Unlock ECU (FRF)” with the unlock file, then you needs to “Full flash unlocked” with your file.

@bri3d
Copy link
Owner

bri3d commented Jun 24, 2022

VW_flash starts unpacking something and stops at 80 with an error in the log window

Please post errors if you have them. If you don't post the error, I can't look into it...

@bri3d
Copy link
Owner

bri3d commented Jun 24, 2022

I do see in the logs that you posted (thank you for doing this! I didn't see them at first! I need to improve error logging for exceptions so that they show in logs too...) that something strange might be going on here.

The logs end with

2022-06-24 10:59:47 [INFO] FlashUtils: Encrypting FD_1 compressed size :697620

This suggests to me that there might be an issue with the padding being applied by lzss as this does not correctly end on a 16 byte boundary.

What version of VW_Flash are you using? Are you using a released version or a version you made yourself?

I have recently made changes to the compressor to support "exact length" control modules. These changes are not yet in a "stable" release (I try very hard to make sure stable releases are truly stable), but they are in pre-releases and Git. They should not have an effect on Simos compression, and I did test via both automation and flashing my own car to verify, but these files particularly may be producing a side effect I didn't notice. I'll take a look.

@bri3d
Copy link
Owner

bri3d commented Jun 24, 2022

I did a quick differential diagnosis.

This is a bug in the latest versions of VW_Flash caused by my compression changes.

Please revert to the v0.2.11 tag, either by downloading the release or git checkout . make sure that if you rebuilt lzss you do so again after checking out the older version.

For those following along, if you do have issues, reverting to the last "stable" release tag is usually a safe bet as I ensure these have been fairly extensively tested prior to promotion to stable.

I'll make a fix later today, it's a simple issue.

@ButcherDSM
Copy link
Author

You selected the wrong unlock, you needs to select “Unlock ECU (FRF)” with the unlock file, then you needs to “Full flash unlocked” with your file.

i do exactly that
first unlock goes fine
in the second step when i choose full flash unlocked - its freezes at 80

@bri3d
Copy link
Owner

bri3d commented Jun 24, 2022

You did everything correctly. Thank you again also for posting logs in your first post. You found a bug in my latest code changes. #57 (comment)

@ButcherDSM
Copy link
Author

I do see in the logs that you posted (thank you for doing this! I didn't see them at first! I need to improve error logging for exceptions so that they show in logs too...) that something strange might be going on here.

The logs end with

2022-06-24 10:59:47 [INFO] FlashUtils: Encrypting FD_1 compressed size :697620

This suggests to me that there might be an issue with the padding being applied by lzss as this does not correctly end on a 16 byte boundary.

What version of VW_Flash are you using? Are you using a released version or a version you made yourself?

I have recently made changes to the compressor to support "exact length" control modules. These changes are not yet in a "stable" release (I try very hard to make sure stable releases are truly stable), but they are in pre-releases and Git. They should not have an effect on Simos compression, and I did test via both automation and flashing my own car to verify, but these files particularly may be producing a side effect I didn't notice. I'll take a look.

exactly! in error exist srting ".... not correctly end on a 16 byte boundary."
i use latest release, but not stable

i try stable version in few days and write to you
thanks for your help!

@bri3d
Copy link
Owner

bri3d commented Jun 24, 2022

I fixed this on latest master . I also deleted the pre-releases as it seems they were causing issues. I will push another pre-release when I have some more new features ready to test.

Thank you for testing and reporting the issue!

@bri3d bri3d closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants