Compiler dirs prefix #1353
Merged
Compiler dirs prefix #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the user can overwrite them by setting the preference. Previously, the dirs were always appended (for Cython) or prepended (for C++ standalone).
|
@denisalevi This should work for you, right? |
|
Yes, works for me! Clean solution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1333. The
sys.prefixsetting was prepended to the preferences forinclude_dirs/library_dirs/runtime_library_dirsin standalone mode, but appended in Cython (andruntime_library_dirswas completely ignored in Cython).This is now uniform, the
sys,prefixsetting is simply the default for the respective preference, so the user can overwrite it completely if they prefer.