fix tests on new versions of postgres #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verified test suite on pg@8.4, pg@9.1, and pg@9.2 ubuntu 64-bit 10.4 node v0.10.4 |
brianc
added a commit
that referenced
this pull request
Apr 17, 2013
fix tests on new versions of postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test suite to run on both postgres >= 9.2 and postgres <= 9.2.
In 9.2 the postgres team changed some names of some columns in the pg_activity_stat table. This table is used by some tests to look up current queries and connections and forcibly terminate them to simulate disconnects & query errors. Since the columns changed names these tests broke.
It sucks to have to do "if this version run this query or if that version run that query" but that's the best fix I could come up with.
this closes #261