Fix long-standing hanging SSL connection but with JavaScript #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had accepted the pull request way back without proper test coverage. I've added test coverage & fixed this long-standing bug.
|
👍 |
brianc
added a commit
that referenced
this pull request
Jul 1, 2013
Fix long-standing hanging SSL connection but with JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing event emitters on the stream before upgrading to a TLS connection prevented anything from happening after that point. The connection just "hung" forever. This would prevent anyone from being able to connect to Heroku Postgres from outside of the Heroku cloud using the pure JavaScript bindings because Heroku requires SSL connections for external clients.
This was one of the few pieces of code I merged in a long time ago without having a proper integration test for it. Shame on me for that! 🙅 I've written a test to make sure it doesn't happen again. The test uses a free instance of Heroku Postgres to make sure everything works properly. Special thanks to @memosanchez for helping me track this down yesterday!