Use the correct environment variable for defaults on Windows #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv.USER as default value for user and database on Windows platforms
|
Nice - I appreciate this. Kinda funny travis failed on it....looks like there's a problem with my build script. Anyways, thanks! 👍 |
brianc
added a commit
that referenced
this pull request
Nov 20, 2013
Use the correct environment variable for defaults on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses the USERNAME environment variable instead of the USER environment variable for the current user so the default for pg doesn't work on windows.
This tiny patch gets this right.
I've opted for process.platform instead of os.platform() as I didn't want to introduce a require('os') into defaults.js but if using one or the other is more than a matter of taste (which I don't think) yout migth want to use os.platform() instead.
Didn't test anything but Windows but I don't expect any problems with this two-liner.
Regards,
Brar