Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Technical Support] LPS-85875 Do not delete the structure if it belongs to a different group #64678

Closed
wants to merge 1 commit into from

Conversation

rafaprax
Copy link

Hi @rafaprax,

I just reviewed this pull request and it looks good to me. If you need any clarification, please ask @robertoDiaz.

Thanks.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@rafaprax
Copy link
Author

/cc @natocesarrego

:octocat: Sent from GH.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 4 seconds 8 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5fea897a9aa58293159419441ee0adca5a59b2b5

Sender Branch:

Branch Name: pr-905
Branch GIT ID: 578469329ebe6bb64862beb88cbe64558550d32a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@rafaprax


However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen


Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #256885
         [exec] :apps:frontend-taglib:frontend-taglib-clay:buildCSS
         [exec] :apps:portal-template:portal-template-soy-api:transpileJS SKIPPED
         [exec] :apps:portal-template:portal-template-soy-api:configJSModules SKIPPED
         [exec] :apps:portal-template:portal-template-soy-api:replaceSoyTranslation NO-SOURCE
         [exec] :apps:portal-template:portal-template-soy-api:wrapSoyAlloyTemplate SKIPPED
         [exec] :downloadNode
         [exec] :apps:frontend-taglib:frontend-taglib-clay:buildCSS NO-SOURCE
         [exec] :apps:frontend-taglib:frontend-taglib-clay:processResources
         [exec] :apps:frontend-taglib:frontend-taglib-soy:transpileJS SKIPPED
         [exec] :apps:frontend-taglib:frontend-taglib-soy:configJSModules SKIPPED
         [exec] :apps:frontend-taglib:frontend-taglib-soy:replaceSoyTranslation NO-SOURCE
         [exec] :apps:frontend-taglib:frontend-taglib-soy:wrapSoyAlloyTemplate SKIPPED
         [exec] :apps:configuration-admin:configuration-admin-api:compileJava
         [exec] :apps:frontend-taglib:frontend-taglib-clay:expandJSCompileDependencies UP-TO-DATE
         [exec] :apps:frontend-taglib:frontend-taglib-clay:wrapSoyAlloyTemplate SKIPPED
         [exec] :core:petra:petra-reflect:compileJava
         [exec] :core:registry-api:compileJava UP-TO-DATE
         [exec] :core:registry-api:buildCSS NO-SOURCE
         [exec] :core:registry-api:processResources
         [exec] :core:petra:petra-reflect:compileJava UP-TO-DATE
         [exec] :core:petra:petra-reflect:buildCSS NO-SOURCE
         [exec] :core:petra:petra-reflect:processResources
         [exec] :core:registry-api:processResources UP-TO-DATE
         [exec] :core:registry-api:transpileJS SKIPPED
         [exec] :core:registry-api:configJSModules SKIPPED
         [exec] :core:registry-api:copyLibs SKIPPED
         [exec] :core:registry-api:replaceSoyTranslation NO-SOURCE
         [exec] :core:registry-api:wrapSoyAlloyTemplate SKIPPED
         [exec] :core:registry-api:classes UP-TO-DATE
         [exec] :core:registry-api:jar
         [exec] :core:petra:petra-reflect:processResources UP-TO-DATE
         [exec] :core:petra:petra-reflect:transpileJS SKIPPED
         [exec] :core:petra:petra-reflect:configJSModules SKIPPED
         [exec] :core:petra:petra-reflect:copyLibs SKIPPED
         [exec] :core:petra:petra-reflect:replaceSoyTranslation NO-SOURCE
         [exec] :core:petra:petra-reflect:wrapSoyAlloyTemplate SKIPPED
         [exec] :core:petra:petra-reflect:classes UP-TO-DATE
         [exec] :core:petra:petra-reflect:jar

@rafaprax
Copy link
Author

ci:reopen

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 17 minutes 41 seconds 987 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5fea897a9aa58293159419441ee0adca5a59b2b5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9eec4e79d18eba0450364385348bac6d54a120b7

20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #256885
           [exec] :apps:frontend-taglib:frontend-taglib-clay:buildCSS
           [exec] :apps:portal-template:portal-template-soy-api:transpileJS SKIPPED
           [exec] :apps:portal-template:portal-template-soy-api:configJSModules SKIPPED
           [exec] :apps:portal-template:portal-template-soy-api:replaceSoyTranslation NO-SOURCE
           [exec] :apps:portal-template:portal-template-soy-api:wrapSoyAlloyTemplate SKIPPED
           [exec] :downloadNode
           [exec] :apps:frontend-taglib:frontend-taglib-clay:buildCSS NO-SOURCE
           [exec] :apps:frontend-taglib:frontend-taglib-clay:processResources
           [exec] :apps:frontend-taglib:frontend-taglib-soy:transpileJS SKIPPED
           [exec] :apps:frontend-taglib:frontend-taglib-soy:configJSModules SKIPPED
           [exec] :apps:frontend-taglib:frontend-taglib-soy:replaceSoyTranslation NO-SOURCE
           [exec] :apps:frontend-taglib:frontend-taglib-soy:wrapSoyAlloyTemplate SKIPPED
           [exec] :apps:configuration-admin:configuration-admin-api:compileJava
           [exec] :apps:frontend-taglib:frontend-taglib-clay:expandJSCompileDependencies UP-TO-DATE
           [exec] :apps:frontend-taglib:frontend-taglib-clay:wrapSoyAlloyTemplate SKIPPED
           [exec] :core:petra:petra-reflect:compileJava
           [exec] :core:registry-api:compileJava UP-TO-DATE
           [exec] :core:registry-api:buildCSS NO-SOURCE
           [exec] :core:registry-api:processResources
           [exec] :core:petra:petra-reflect:compileJava UP-TO-DATE
           [exec] :core:petra:petra-reflect:buildCSS NO-SOURCE
           [exec] :core:petra:petra-reflect:processResources
           [exec] :core:registry-api:processResources UP-TO-DATE
           [exec] :core:registry-api:transpileJS SKIPPED
           [exec] :core:registry-api:configJSModules SKIPPED
           [exec] :core:registry-api:copyLibs SKIPPED
           [exec] :core:registry-api:replaceSoyTranslation NO-SOURCE
           [exec] :core:registry-api:wrapSoyAlloyTemplate SKIPPED
           [exec] :core:registry-api:classes UP-TO-DATE
           [exec] :core:registry-api:jar
           [exec] :core:petra:petra-reflect:processResources UP-TO-DATE
           [exec] :core:petra:petra-reflect:transpileJS SKIPPED
           [exec] :core:petra:petra-reflect:configJSModules SKIPPED
           [exec] :core:petra:petra-reflect:copyLibs SKIPPED
           [exec] :core:petra:petra-reflect:replaceSoyTranslation NO-SOURCE
           [exec] :core:petra:petra-reflect:wrapSoyAlloyTemplate SKIPPED
           [exec] :core:petra:petra-reflect:classes UP-TO-DATE
           [exec] :core:petra:petra-reflect:jar

Failures in common with acceptance upstream results at 5fea897:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    197 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #195085
      1. ProjectTemplatesTest.testBuildTemplateRest71
        java.lang.AssertionError: [INFO] Error stacktraces are turned on.
        [INFO] Scanning for projects...
        [INFO] 
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Maven Stub Project (No POM) 1
        [INFO] ------------------------------------------------------------------------
        [INFO] 
        [INFO] >>> maven-archetype-plugin:3.0.1:generate (default-cli) > generate-sources @ standalone-pom >>>
        [INFO] 
        [INFO] <<< maven-archetype-plugin:3.0.1:generate (default-cli) < generate-sources @ standalone-pom <<<
        [INFO] 
        [INFO] 
        [INFO] --- maven-archetype-plugin:3.0.1:generate (default-cli) @ standalone-pom ---
        [INFO] Generating project in Batch mode
        [INFO] Archetype repository not defined. Using the one from [com.liferay:com.liferay.project.templates.rest:1.0.9 -> https://repository-cdn.liferay.com/nexus/content/groups/public] found in catalog remote
        [INFO] ----------------------------------------------------------------------------
        [INFO] Using following parameters for creating project from Archetype: com.liferay.project.templates.rest:1.0.18
        [INFO] ----------------------------------------------------------------------------
        [INFO] Parameter: groupId, Value: com.test
        [INFO] Parameter: artifactId, Value: my-rest
        [INFO] Parameter: version, Value: 1.0.0
        [INFO] Parameter: package, Value: my.rest
        [INFO] Parameter: packageInPathFormat, Value: my/rest
        [INFO] Parameter: liferayVersion, Value: 7.1
        [INFO] Parameter: author, Value: root
        [INFO] Parameter: groupId, Val...

@jpince
Copy link
Collaborator

jpince commented Oct 31, 2018

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 6 minutes 23 seconds 277 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5fea897a9aa58293159419441ee0adca5a59b2b5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9eec4e79d18eba0450364385348bac6d54a120b7

21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 5fea897:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    197 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #266750
      1. ProjectTemplatesTest.testBuildTemplateRest71
        java.lang.AssertionError: [INFO] Error stacktraces are turned on.
        [INFO] Scanning for projects...
        [INFO] 
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Maven Stub Project (No POM) 1
        [INFO] ------------------------------------------------------------------------
        [INFO] 
        [INFO] >>> maven-archetype-plugin:3.0.1:generate (default-cli) > generate-sources @ standalone-pom >>>
        [INFO] 
        [INFO] <<< maven-archetype-plugin:3.0.1:generate (default-cli) < generate-sources @ standalone-pom <<<
        [INFO] 
        [INFO] 
        [INFO] --- maven-archetype-plugin:3.0.1:generate (default-cli) @ standalone-pom ---
        [INFO] Generating project in Batch mode
        [INFO] Archetype repository not defined. Using the one from [com.liferay:com.liferay.project.templates.rest:1.0.9 -> https://repository-cdn.liferay.com/nexus/content/groups/public] found in catalog remote
        [INFO] ----------------------------------------------------------------------------
        [INFO] Using following parameters for creating project from Archetype: com.liferay.project.templates.rest:1.0.18
        [INFO] ----------------------------------------------------------------------------
        [INFO] Parameter: groupId, Value: com.test
        [INFO] Parameter: artifactId, Value: my-rest
        [INFO] Parameter: version, Value: 1.0.0
        [INFO] Parameter: package, Value: my.rest
        [INFO] Parameter: packageInPathFormat, Value: my/rest
        [INFO] Parameter: liferayVersion, Value: 7.1
        [INFO] Parameter: author, Value: root
        [INFO] Parameter: groupId, Val...

@brianchandotcom
Copy link
Owner

Please send a backport to support like our normal support workflow.

Merged into master only. Thank you.

@jhendley @liferay @zsoltbalogh FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants