Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

look: simplify program #645

Merged
merged 1 commit into from
Jun 6, 2024
Merged

look: simplify program #645

merged 1 commit into from
Jun 6, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 6, 2024

  • Main file loop is not needed because we only search in one file; the loop was only to determine which file to search
  • Remove the need for globals $opened and $found
  • Introduce a search function which returns found/not-found
  • pod: add a leading dash to the option letters to make it clearer

@mknos
look: simplify program
9ec5e02 
* Main file loop is not needed because we only search in one file; the loop was only to determine which file to search
* Remove the need for globals $opened and $found
* Introduce a search function which returns found/not-found
* pod: add a leading dash to the option letters to make it clearer
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: look The look program labels Jun 6, 2024
@briandfoy briandfoy added the Type: documentation fix the docs label Jun 6, 2024
@briandfoy briandfoy merged commit 7d4c323 into briandfoy:master Jun 6, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 6, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: look The look program Status: released there is a new release with this fix Type: documentation fix the docs Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy