Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward color option behavior #103

Closed
lukasmalkmus opened this issue Oct 19, 2020 · 2 comments
Closed

Awkward color option behavior #103

lukasmalkmus opened this issue Oct 19, 2020 · 2 comments

Comments

@lukasmalkmus
Copy link

lukasmalkmus commented Oct 19, 2020

I kinda like how configuring a spinner works, but setting a color is awkward. While the usage is documented and states, that the spinner is restarted with the given color, this is kinda awkward when using it in a constructor:

// This spinner starts right away:
sp := spinner.New(
	spinner.CharSets[11],
	time.Millisecond*100,
	spinner.WithColor("green"),
)

Maybe this should be revisited since the default state of a spinner should be stopped.

@briandowns
Copy link
Owner

Latest release removes the restart. https://github.com/briandowns/spinner/releases/tag/v1.12

@lukasmalkmus
Copy link
Author

Guess this can be closed? Latest release seemed to work fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants