Fix potential bad read #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffer left and have peeked ahead to see that a unicode escape is approaching. Thanks @kivikakk for helping me track down the actual bug here!
zerebubuth
pushed a commit
to tilezen/chef-joerd
that referenced
this pull request
Nov 29, 2017
Make sure to use version 1.3.1 or later to include fix in brianmario/yajl-ruby#178.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 9, 2017
No upstream changelog, but seems to include security fixes CVE-2017-16516 and others: brianmario/yajl-ruby#176 brianmario/yajl-ruby#178
jeroen
added a commit
to jeroen/jsonlite
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding a string with escape sequences sure we need to make sure we don't advance our
endpointer until we've checked we have enough buffer left to parse, as well as have peeked ahead to see that a unicode escape is approaching.Thanks @kivikakk for helping me track down the actual bug here! (Previous attempt here)
This fix should be applied upstream on yajl itself as well, but I'm starting here since that's where the original issue was reported and we have a patched yajl embedded anyway.
Fixes #176