Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse cqlSchema manually to avoid limitations of univocity csv parser #66

Closed
wants to merge 1 commit into from

Conversation

alfredo-gimenez
Copy link

@alfredo-gimenez alfredo-gimenez commented Jan 27, 2017

Fixes issue #65
EDIT: and #74

@jbax
Copy link

jbax commented Jan 31, 2017

Hi there the parser is not restricted to 4096 characters, this is just the default limit. You can increase it or simply set the limit to -1 to not have a limit at all.

As per javadoc, all you need to do is to use:

settings.setMaxCharsPerColumn(-1); and be done with it.

Hope this helps.

@alfredo-gimenez
Copy link
Author

Sure, but using the csv parser with parentheses delimiters also causes other problems.

Consider the valid table:

CREATE TABLE test.blah (
    "blee(blorg)" int PRIMARY KEY,
    "bloo.blarg" text
)

This pull request fixes those bugs as well.

@jbax
Copy link

jbax commented Feb 1, 2017

Got it! Why on earth would someone try to parse a CREATE TABLE statement with a CSV parser? That's bound to cause havoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants