Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary suffix to Taiwan name #2957

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

kylekatarnls
Copy link
Collaborator

Fix #2956

Note for people needing custom region names: you can still use the previous name or any other and you can more generally choose your own name for any code

$locale = new Language('zh_TW');

$region = match ($locale->getRegion()) {
    // Here you can override whatever code
    'TW' => 'The name you want for TW in your app',
    'US' => 'The name you want for US in your app',
    //...
    default => $locale->getRegionName(),
};

One more note: Carbon and its contributor are not siding neither against nor for the unification and do not intent to give any political opinion on the Taiwan government matter. We genuinely intend to provide an unambiguous and respectful name to locate the ISO code "TW" and to keep it short if possible cutting anything not strictly necessary to serve this purpose.

#2956 (comment)

@kylekatarnls kylekatarnls added this to the 3.1.0 milestone Mar 6, 2024
@kylekatarnls kylekatarnls merged commit 237716a into master Mar 6, 2024
36 checks passed
@kylekatarnls kylekatarnls deleted the fix/tw-name branch March 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taiwan is NOT the Province of China
1 participant