Fixing #871, workaround of php bug [72338](https://bugs.php.net/bug.php?id=72338) #900
Conversation
|
<3 |
src/Carbon/Carbon.php
Outdated
| @@ -943,7 +943,11 @@ public function tz($value) | |||
| */ | |||
| public function setTimezone($value) | |||
| { | |||
| return parent::setTimezone(static::safeCreateDateTimeZone($value)); | |||
| $date = parent::setTimezone(static::safeCreateDateTimeZone($value)); | |||
There was a problem hiding this comment.
Can we use $instance instead?
There was a problem hiding this comment.
Ofc, we can. Or even better, we can use $this. I will try it.
There was a problem hiding this comment.
Okay, i made it and updated the branch
| * | ||
| * @internal I use days changing in tests because using seconds|minute|hours may run setTimezone within. | ||
| */ | ||
| class PhpBug72338Test extends AbstractTestCase |
There was a problem hiding this comment.
I think I would put this specific tests in the dedicated existing test classes
There was a problem hiding this comment.
Do you mean that you will do it by yourself? I dont know how modifying pull-request works, so if you need anything from me - just ask.
| $date = Carbon::createFromTimestamp(0); | ||
| $date->setTimezone('+02:00'); | ||
| $date->modify('+1 day'); | ||
| $this->assertSame('86400', $date->format('U')); |
There was a problem hiding this comment.
Maybe a stricter assertion would be fine too? as $date->format('U') always returns an integer.
There was a problem hiding this comment.
I dont get your point. What do you mean? $date->format('U') always returns string as i know.
There was a problem hiding this comment.
If you want we can discuss all this things on Discord (it has web-interface, so you don't need to install anything): https://discord.gg/FDbay
….net/bug.php?id=72338) The problem is, that $date->setTimezone($tz) with $tz in 'HH:MM' notation (["timezone_type"]=>int(1)) put DateTime object on inconsistent state. It looks like internal timestamp becomes changed and it affects to such functions: * $date->modify() uses changed timestamp and result is wrong * $date->setTimezone($tz) settle this changed timestamp, even in case if $tz is not in 'HH:MM' format * $date->format('U') returns changed timestamp I founded the workaround: if you run DateTime::getTimestamp() method after setting such timezone, internal structure of DateTime seems fixed - it behavior looks right in such cases described above. So i added call to getTimestamp() in setTimezone().
No description provided.