Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the plugin does not work with videojs 4.9+ #8

Closed
koenokatachi opened this issue May 6, 2015 · 5 comments
Closed

the plugin does not work with videojs 4.9+ #8

koenokatachi opened this issue May 6, 2015 · 5 comments

Comments

@koenokatachi
Copy link

videojs css for versions below 4.9 has

.vjs-default-skin .vjs-menu-button:hover .vjs-menu{
    display:block
}

for 4.9+ it is

.vjs-default-skin .vjs-menu-button:hover .vjs-control-content .vjs-menu,.vjs-default-skin .vjs-control-content .vjs-menu.vjs-lock-showing{
    display:block
}

so 4.9+ supposes .vjs-menu inside of .vjs-control-content but ur plugin puts them along as sibling nodes.

because of this the sharing menu doesnt open on hovering the plugin button

@brianpkelley
Copy link
Owner

Thank you for the heads up. I've been rather busy with a newborn and work, I'll try to address asap.

Do you have an example I could look at?

I'll keep this issue open for other people as well.

@koenokatachi
Copy link
Author

cheers to ur baby ^^ and thanks for ur time

here is a demo http://37.1.195.56/share/vjs/

as is it loads vjs 4.9.1.

u can change the vjs version it loads via the "v" url parameter.
for example http://37.1.195.56/share/vjs/?v=4.8.5 load vjs 4.8.5

what i mean sayin "it doesnt work". open a link and hover the addthis plugin button. in vjs 4.9+ the menu doesnt show itself on the button hovering.

so it works in
http://37.1.195.56/share/vjs/?v=4.5.2
http://37.1.195.56/share/vjs/?v=4.6.4
http://37.1.195.56/share/vjs/?v=4.7.3
http://37.1.195.56/share/vjs/?v=4.8.5

but it doesnt work in
http://37.1.195.56/share/vjs/?v=4.9.1
http://37.1.195.56/share/vjs/?v=4.10.2
http://37.1.195.56/share/vjs/?v=4.11.4
http://37.1.195.56/share/vjs/?v=4.12.5

check out my first comment for some details

brianpkelley added a commit that referenced this issue May 6, 2015
@brianpkelley
Copy link
Owner

Can you pull down the latest file and test again. I removed the custom createEl function from the menu button which seems to have fixed the issue.

@koenokatachi
Copy link
Author

ive updated my demo. yes, it looks like fixed. thanks

@brianpkelley
Copy link
Owner

Thanks for reporting and the help getting this resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants