Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of addressing #744
For many types in
libc
(uint8_t
,int32_t
, etc...) we assume these types are equivalent to certain Rust types (u8
,i32
, etc...) even iflibc
is empty. This PR does three things:size_t
tousize
, as they are definitionally the same type. This is equivalence is currently assumed by ring anyway, and it is also assumed by Rust itself in things likememcpy
.GFp_memcmp
to return au8
instead of a int. This fits better with the functions implementation, and the return value is only ever compared to zero anyway. As a side note, is there any reason this function cannot be written in Rust?getrandom
syscall. This has been inlibc
for a while, so we don't need to increment thelibc
version inCargo.toml
.Now the only necessary C types are for
bssl::Result
and a bunch of one-off code inaead/aes.rs
, which I'll address in a future CL.