Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nasm #905

Closed
wants to merge 4 commits into from
Closed

Conversation

Jake-Shadle
Copy link

@Jake-Shadle Jake-Shadle commented Oct 12, 2019

I was having issues with yasm on Windows, and noticed #752, so I just tried out nasm instead and everything seemed to work.

Resolves: #752

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
mk/appveyor.bat Show resolved Hide resolved
@briansmith briansmith reopened this Dec 23, 2019
@briansmith
Copy link
Owner

@Jake-Shadle Are you interested in updating this based on the above feedback?

build.rs Outdated Show resolved Hide resolved
@briansmith briansmith changed the base branch from master to main June 19, 2020 17:22
@briansmith
Copy link
Owner

Thanks for the PR and thanks for updating it in response to my previous comment. I haven't had time to test it out but I will do so if/when you rebase it.

I think we should check to see which version of nasm BoringSSL is using and use the same version.

@Jake-Shadle
Copy link
Author

I updated the version to the one that boringssl ostensibly is using as seen https://boringssl.googlesource.com/boringssl/+/HEAD/util/bot/UPDATING#56

@briansmith
Copy link
Owner

@Jake-Shadle Thanks for the PR. I had to rewrite the CI/CD to replace Travis CI and AppVeyor with GitHub Actions. That makes your PR unmergable. I'm going to close this. I have written a new PR #1123 that attempts to accomplish the same thing yours does. I would appreciate it if you could take a look.

@briansmith briansmith closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Yasm to NASM on Windows
2 participants