Add support for Ed25519 certificates #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Thanks!
Please add the statement about the license from https://github.com/briansmith/ring#contributing to the commit message and I'll merge this.
This adds support for verification of ed25519 certificates according to RFC 8410. Implements briansmith#49. The test certificate was generated using OpenSSL 1.1.1a, using the following commands (CA.pl is distributed with OpenSSL): openssl genpkey -algorithm ed25519 -outform pem -out root_key.pem openssl req -new -x509 -days 9999 -extensions v3_ca -key root_key.pem \ -inform pem -outform pem -out root_ed25519.pem echo root_ed25519.pem | CA.pl -newca openssl genpkey -algorithm ed25519 -outform pem -out client_key.pem openssl req -new -key client_key.pem -inform pem -outform pem \ -out client_ed25519_csr.pem openssl ca -keyfile ./root_key.pem -days 999 -notext -in \ client_ed25519_csr.pem -out client_ed25519.pem I agree to license my contributions to each file under the terms given at the top of each file I changed.
|
Thanks, addressed review & pushed new commit with altered commit message. |
briansmith
approved these changes
Jan 19, 2019
|
Thanks! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for verification of ed25519 certificates according to
RFC 8410. Implements #49.
The test certificate was generated using OpenSSL 1.1.1a, using the
following commands (CA.pl is distributed with OpenSSL):
CA:
openssl genpkey -algorithm ed25519 -outform pem -out root_key.pem
openssl req -new -x509 -days 9999 -extensions v3_ca -key root_key.pem
-inform pem -outform pem -out root_ed25519.pem
echo root_ed25519.pem | CA.pl -newca
Client:
openssl genpkey -algorithm ed25519 -outform pem -out client_key.pem
openssl req -new -key client_key.pem -inform pem -outform pem
-out client_ed25519_csr.pem
openssl ca -keyfile ./root_key.pem -days 999 -notext -in
client_ed25519_csr.pem -out client_ed25519.pem