Added tests for Doctrine Types

[cevou]

This adds integration tests for the doctrine types. I had to adjust some code, so everything works with PostgreSQL. The tests uses the DbalFunctionalTestCase as base, which is not part of the doctrine archive. Thats why I changed the composer install to prefer sources.

[coveralls]

Coverage decreased (-14.87%) when pulling 38cecde on cevou:type_tests into ebba501 on brick:master.

[BenMorel]

Could you please use PHP 5.5's ::class syntax here: use Brick\Geo\Doctrine\Types; at the top of the file, then addType('...', Types\GeometryType::class);.

[BenMorel]

Thanks for the PR!

I had to adjust some code, so everything works with PostgreSQL.

If I understand correctly from your code, PostGIS has a single GEOMETRY column type, and no sub-types such as POINT and POLYGON?

[cevou]

There is a geography type (http://postgis.net/docs/manual-2.1/using_postgis_dbmanagement.html#PostGIS_Geography) with which you can create more specific fields like location GEOGRAPHY(POINT,SRID). Should we use this type? It only supports POINT, LINESTRING, POLYGON, MULTIPOINT, MULTILINESTRING, MULTIPOLYGON and GEOMETRYCOLLECTION.

[BenMorel]

I'm not sure we should venture into the territory of Geometry vs. Geography for now: there are other implications AFAIK with Geography, related to how distances are calculated etc.
If Geometry does not have sub-types, let's use this one for now?

[cevou]

Thats's OK for me.

[coveralls]

Coverage decreased (-14.87%) when pulling c08e9c0 on cevou:type_tests into ebba501 on brick:master.

[BenMorel]

Could you use preferred-install in composer.json instead? So that no-one is confused by missing classes when cloning the repo and running a bare composer install.

[BenMorel]

It would be nice to specify process-timeout as well: on my machine, cloning Doctrine repos exceeded the default 300 seconds timeout, so Composer reverted to dist install. Setting process-timeout to 600 worked.

[cevou]

If we set the prefer source within the composer.json the packages will always be iinstalled from source. Put this is only required if you want to run the tests. In productive usage it is better to have them loaded from archive. What do you think?

[BenMorel]

The doc says that these settings only apply to projects, so it should only apply when you run composer install from within the brick\geo repository (that is, when you're developing the library) not when it's included as a dependency of a third-party project!

[coveralls]

Coverage decreased (-9.53%) to 57.35% when pulling 658dffb on cevou:type_tests into ebba501 on brick:master.

[BenMorel]

Looks good. Thanks!