Money::allocate() fixed bug when Money was negative #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenMorel
reviewed
Dec 1, 2017
src/Money.php
Outdated
| @@ -537,6 +540,8 @@ public function allocate(int ...$ratios) : array | |||
| $remainder = $remainder->minus($unit); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No assertions please, I don't use them anywhere else in this library, and test cases are expected to catch the bugs (a test case for negative numbers was missing though, as you found out! 👍 )
BenMorel
reviewed
Dec 1, 2017
src/Money.php
Outdated
| @@ -519,6 +519,9 @@ public function allocate(int ...$ratios) : array | |||
|
|
|||
| $unit = BigDecimal::ofUnscaledValue($step, $this->amount->getScale()); | |||
| $unit = new Money($unit, $this->currency, $this->context); | |||
| if ($this->isNegative()) { | |||
There was a problem hiding this comment.
Can you add a newline above this one, this keeps the code easier to read.
|
Good catch, thanks! 👍 |
trebi
force-pushed
the
fix-money-allocate
branch
from
071d345
to
d6ff383
Compare
|
✔️ changed |
|
Thanks! Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.