Add support for exporting Enums when using PHP8.1+ #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your PR! Can you please add a test? |
BenMorel
reviewed
Jun 15, 2022
Working on it, however, since Enums are not supported on PHP < 8.1.0 I'm sort of struggling on what to assert on the test, as trying to get a reflection of the Enum itself throws a syntax error, since the |
|
I have added the Enum test on PHP 8.1+ and currently skipped the test on lower versions, as instantiating the test itself throws an exception due to invalid keyword. |
|
Thank you, @Jacobs63! I fixed Psalm issues and squashed your commits. |
|
Released as 0.3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for exporting Enums when using PHP8.1+
Enums are considered objects which cannot be instantiated, this caused a fatal error when using the var exporter:
This pull requests enables support for exporting Enums, disabling exporting of Enums & keeps support for previous PHP versions without breaking changes.