Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Check resource-based policies for public access #3989

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

2 new policies that check resource-based policies for public actions

New/Edited policies (Delete if not relevant)

Description

Resource-based policies can allow public access to the resource. This should be avoided

Fix

Either change the principal to something more specific than "*" or "AWS": "*", or add a Condition block

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@nimrodkor nimrodkor merged commit 2b1acfa into main Dec 6, 2022
@nimrodkor nimrodkor deleted the check_resource_based_policy_for_public_access branch December 6, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants