Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): Bump detect secrets version #3997

Merged
merged 10 commits into from
Dec 7, 2022
Merged

Conversation

arielkru
Copy link
Collaborator

@arielkru arielkru commented Dec 7, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

The change in detect secrets now adds 2 private key secrets to the test results
(the secrets were also detected before the change, but for some reason when they were supposed to be added to the secrets result set, they weren't added. Possibly their addition now is caused by the fact that the new returned values have a different hash)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@arielkru arielkru marked this pull request as ready for review December 7, 2022 00:45
@arielkru arielkru merged commit a5ecccd into main Dec 7, 2022
@arielkru arielkru deleted the bump-detect-secrets branch December 7, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants