Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Extend secret attributes to omit mapping #4028

Merged
merged 12 commits into from
Dec 12, 2022
Merged

feat(terraform): Extend secret attributes to omit mapping #4028

merged 12 commits into from
Dec 12, 2022

Conversation

arielkru
Copy link
Collaborator

@arielkru arielkru commented Dec 9, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Added azurerm potentialy sensitive attributes to mask from tfplan results
  • Changed the mapping to support multiple attributes per resource type instead of just one

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@arielkru arielkru marked this pull request as ready for review December 9, 2022 16:30
gruebel
gruebel approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just minor suggestions

checkov/common/util/secrets.py Outdated Show resolved Hide resolved
checkov/terraform/plan_runner.py Show resolved Hide resolved
@arielkru arielkru merged commit d0b30a9 into main Dec 12, 2022
@arielkru arielkru deleted the extend_secret_attributes_to_omit branch December 12, 2022 13:35
gruebel pushed a commit to ssiddardha/checkov that referenced this pull request Dec 12, 2022
@arielkru @actions-user
feat(terraform): Extend secret attributes to omit mapping (bridgecrew…
5537092 
…io#4028)

* handle omitting multiline secrets by attribute

* extend mapping

* remove multiline commits

* ignore None option for list

* update tests

* improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielkru @gruebel @lirshindalman @Eliran-Turgeman