Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(circleci): add resource to ir #4135

Merged
merged 2 commits into from
Dec 22, 2022
Merged

fix(circleci): add resource to ir #4135

merged 2 commits into from
Dec 22, 2022

Conversation

marynaKK
Copy link
Contributor

@marynaKK marynaKK commented Dec 22, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Images can be found in executors or jobs in circleci.
originally, jobs... entity was not included in the supported_entities.
This check should have all the resources that have IR findings, even if they exist in some other check.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@marynaKK marynaKK changed the title fix(circleci_pipelines): add resource to ir fix(circleci): add resource to ir Dec 22, 2022
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also write in the PR description, what/why you did it 🙂

@marynaKK
Copy link
Contributor Author

@gruebel - I added the explanation in the description :)

@marynaKK marynaKK merged commit 4fbe7b7 into main Dec 22, 2022
@marynaKK marynaKK deleted the add-resource-circleci-ir branch December 22, 2022 13:41
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Dec 22, 2022
* add resource to ir to circleci

* fix tests
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Dec 22, 2022
* add resource to ir to circleci

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants