Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): add aws_transfer_server to CKV2_AWS_5 check #4137

Merged
merged 6 commits into from Dec 22, 2022

Conversation

Teko012
Copy link
Contributor

@Teko012 Teko012 commented Dec 22, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

It adds aws_transfer_server to CKV2_AWS_5 check in terraform, as it can use security groups. It also fixes some formatting issues in the same file, so the formatter can pass.

Fixes #4136

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Teko012 Teko012 requested a review from gruebel December 22, 2022 13:42
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work and thanks for your first contribution 🎉

Copy link
Contributor

@marynaKK marynaKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄 🍒

@gruebel gruebel merged commit 302556f into bridgecrewio:main Dec 22, 2022
@Teko012 Teko012 deleted the fix/aws_transfer_server branch December 22, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV2_AWS_5: aws_transfer_server is not checked
3 participants