fix(secrets): Revert "fix(secrets): Change secret validation status message" #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e7275e.
maxamel
approved these changes
Jan 15, 2023
Eliran-Turgeman
changed the title
marynaKK
approved these changes
Jan 15, 2023
Eliran-Turgeman
deleted the
revert-4238-change_secret_validation_status_message
branch
Eliran-Turgeman
added a commit
that referenced
this pull request
Jan 16, 2023
* Revert "fix(secrets): Revert "fix(secrets): Change secret validation status message" (#4248)" This reverts commit 49d78c7. * fix enum case * remove redundant hasattr check * add new status to const Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
praveen-panw
pushed a commit
to praveen-panw/bc_checkov
that referenced
this pull request
Jan 16, 2023
) * Revert "fix(secrets): Revert "fix(secrets): Change secret validation status message" (bridgecrewio#4248)" This reverts commit 49d78c7. * fix enum case * remove redundant hasattr check * add new status to const Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
reemodo
pushed a commit
to reemodo/checkov
that referenced
this pull request
Jan 22, 2023
…essage" (bridgecrewio#4248) Revert "fix(secrets): Change secret validation status message (bridgecrewio#4238)" This reverts commit 8e7275e.
reemodo
pushed a commit
to reemodo/checkov
that referenced
this pull request
Jan 22, 2023
) * Revert "fix(secrets): Revert "fix(secrets): Change secret validation status message" (bridgecrewio#4248)" This reverts commit 49d78c7. * fix enum case * remove redundant hasattr check * add new status to const Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
reemodo
pushed a commit
to reemodo/checkov
that referenced
this pull request
Jan 22, 2023
) * Revert "fix(secrets): Revert "fix(secrets): Change secret validation status message" (bridgecrewio#4248)" This reverts commit 49d78c7. * fix enum case * remove redundant hasattr check * add new status to const Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com> Co-authored-by: Anton Grübel <anton.gruebel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4238