Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes): removed env vars from tests #4252

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Conversation

PelegLi
Copy link
Contributor

@PelegLi PelegLi commented Jan 15, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

manually setting env vars in some tests might have caused inconsistency when running some tests concurrently in jenkins. removing this logic from the tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gruebel gruebel merged commit d15bba0 into main Jan 15, 2023
@gruebel gruebel deleted the remove-env-var-from-tests branch January 15, 2023 16:21
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants