fix(secrets): Change s3 path for enriched secrets upload #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKK
approved these changes
Jan 18, 2023
gruebel
reviewed
Jan 18, 2023
.flake8
Outdated
| @@ -3,7 +3,7 @@ | |||
| [flake8] | |||
| max-line-length = 120 | |||
| # E203,E501 don't work with black together | |||
| ignore = E203,E501,E731,W293,W503,W504,DUO107,DUO104,DUO130,DUO109,DUO116,B028,B950,TC001,TC003,TC006 | |||
| ignore = E203,E501,E731,W293,W503,W504,DUO107,DUO104,DUO130,DUO109,DUO116,B028,B950,TC001,TC003,TC006,B907 | |||
There was a problem hiding this comment.
funny they changed B907 finding to opinionated now 😄
There was a problem hiding this comment.
there is a chance you will need to remove this change, when we merge #4274 tomorrow
gruebel
reviewed
Jan 18, 2023
added 2 commits
January 18, 2023 12:29
gruebel
approved these changes
Jan 18, 2023
.flake8
Outdated
| @@ -3,7 +3,7 @@ | |||
| [flake8] | |||
| max-line-length = 120 | |||
| # E203,E501 don't work with black together | |||
| ignore = E203,E501,E731,W293,W503,W504,DUO107,DUO104,DUO130,DUO109,DUO116,B028,B950,TC001,TC003,TC006 | |||
| ignore = E203,E501,E731,W293,W503,W504,DUO107,DUO104,DUO130,DUO109,DUO116,B028,B950,TC001,TC003,TC006,B907 | |||
There was a problem hiding this comment.
there is a chance you will need to remove this change, when we merge #4274 tomorrow
gruebel
approved these changes
Jan 23, 2023
| ' enabled it via env var CKV_VALIDATE_SECRETS and provide an api key') | ||
| return None | ||
|
|
||
| base_path = re.sub(r'checkov/(.*?)/src', r'original_secrets/\1', self.repo_path) |
There was a problem hiding this comment.
can you just move it r'checkov/(.*?)/src' up to global with a re.compile() then linters can also pick it up better
reemodo
pushed a commit
to reemodo/checkov
that referenced
this pull request
Jan 24, 2023
…o#4275) * change enriched secrets upload path * not persisting enriched secrets if not eligible for secrets verifier * remove unused import * ignore B907 * change path * use re.sub * remove unnecessary regex groups * retry mechanism for upload * remove unused import * increasing sleep * move repo path pattern to const Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Dependent changes has to be merged before merging this PR
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: