Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sca): Fix multiple issues related to IR #4358

Merged
merged 3 commits into from
Jan 29, 2023
Merged

fix(sca): Fix multiple issues related to IR #4358

merged 3 commits into from
Jan 29, 2023

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Identify problematic references to images, i.e.:

  1. Images that are only available locally (localhost) - fetching results from platform may be tainted by images with overlapping names
  2. unrendered image names, such as assigned via variable in runtime or with a replace instruction (see tests)
  3. gracefully handle results without output type

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nimrodkor nimrodkor changed the title fix(sca_image): Fix multiple issues related to IR fix(sca): Fix multiple issues related to IR Jan 29, 2023
@nimrodkor nimrodkor merged commit d89e13e into main Jan 29, 2023
@nimrodkor nimrodkor deleted the skip_problematic_image_references branch January 29, 2023 14:22
gruebel pushed a commit to gruebel/checkov that referenced this pull request Jan 29, 2023
@nimrodkor @actions-user
fix(sca): Fix multiple issues related to IR (bridgecrewio#4358)
6476b43 
* Fix multiple issues related to IR

* Add another test case

* Fix cached_results handling
andyloughran pushed a commit to andyloughran/checkov that referenced this pull request Feb 10, 2023
@nimrodkor @andyloughran
fix(sca): Fix multiple issues related to IR (bridgecrewio#4358)
2cd99d1 
* Fix multiple issues related to IR

* Add another test case

* Fix cached_results handling
andyloughran pushed a commit to andyloughran/checkov that referenced this pull request Feb 10, 2023
@nimrodkor @andyloughran
fix(sca): Fix multiple issues related to IR (bridgecrewio#4358)
0f91809 
* Fix multiple issues related to IR

* Add another test case

* Fix cached_results handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirshindalman lirshindalman lirshindalman approved these changes

@marynaKK marynaKK marynaKK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nimrodkor @lirshindalman @marynaKK