-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): Add resource code filter to all checkov loggers #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng templates from the log
bo156
force-pushed
the
feature/migrate-loggers-to-use-code-filter
branch
from
July 19, 2023 10:42
4fa3f02
to
75f2446
Compare
bo156
force-pushed
the
feature/migrate-loggers-to-use-code-filter
branch
from
July 19, 2023 10:42
75f2446
to
ee0c6cc
Compare
bo156
force-pushed
the
feature/migrate-loggers-to-use-code-filter
branch
from
July 19, 2023 10:43
ee0c6cc
to
69e15de
Compare
ChanochShayner
approved these changes
Jul 19, 2023
omryMen
approved these changes
Jul 19, 2023
pull bot
pushed a commit
to tooniez/checkov
that referenced
this pull request
Jul 19, 2023
…ecrewio#5356) * Created template code for using custom logger which removes code string templates from the log * Added other logging methods and moved env variable to constructor * replaced logger with logger adapter * Added tests * mypy * Renamed to indicate it's general for templates * Renamed files and qfixed mypy * Instead of using a replacement code template, just log empty message * Eventually decided to use logging.Filter as the best option * Add resource code filter to all checkov logs * flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add resource code filter to all checkov loggers
Checklist: