Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create yor_name tag #367

Merged
merged 13 commits into from
May 18, 2023
Merged

Create yor_name tag #367

merged 13 commits into from
May 18, 2023

Conversation

rotemavni
Copy link
Collaborator

@rotemavni rotemavni commented May 16, 2023

Created a new tag under code2cloud called yor_name

This tag tags each resource with their name.
The reason it's named yor_name is to avoid possible collisions with existing tags.

To support this I made. the following changes:

  1. GetResourceName added to the IBlock interface and implemented differently for Terraform
  2. Changed the code2cloud tag group to enable passing the block to the tagger.
  3. Added tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rotemavni rotemavni marked this pull request as ready for review May 16, 2023 09:54
Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/common/tagging/code2cloud/tag_group.go Show resolved Hide resolved
@rotemavni rotemavni merged commit 165347c into main May 18, 2023
@rotemavni rotemavni deleted the resource-name branch May 18, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants