Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Expired builds causing 404s #53

Closed
flynnduism opened this issue Nov 27, 2017 · 3 comments · Fixed by #265
Closed

Expired builds causing 404s #53

flynnduism opened this issue Nov 27, 2017 · 3 comments · Fixed by #265
Labels
bug Something isn't working

Comments

@flynnduism
Copy link
Contributor

When I browse the UI, i'm getting a bunch of 404s for API endpoints in the console:

e.g.
http://acid-api.technosophos.me:7745/v1/project/01bz3j29xmz4dhs99xahm1q9bh
http://acid-api.technosophos.me:7745/v1/project/01bzzn07g488przds1x7n21p2v
http://acid-api.technosophos.me:7745/v1/project/01bzzmz498aqh18hc7j5erjxmm/builds

I think these are endpoints that did exist, but have expired?

Is there a way the UI / API can know the difference between a build which still has data, and one that has expired? Not for MVC, but important UX for launch, to have better error states.

@seanknox
Copy link
Contributor

seanknox commented Dec 3, 2017

@technosophos, what's the thinking behind expiring build history in brigade? If that's not needed, it'd be change in brigade as opposed to kashti + brigade.

@radu-matei radu-matei added the bug Something isn't working label Jan 8, 2019
@radu-matei
Copy link
Contributor

Yeah, same root cause as #213
We should also move all expired builds at the bottom of the view.

@radu-matei
Copy link
Contributor

We could catch any 404s and display a fading red modal at the top saying that the build is no longer available.

For jobs, we could enter the job view and wait for logs to update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants