Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Write new tests and refactor old ones #12

Merged
merged 5 commits into from
Jul 3, 2019
Merged

Conversation

reginafcompton
Copy link
Contributor

@reginafcompton reginafcompton commented Jul 2, 2019

Overview

This PR updates the tests for User endpoints. The cases currently tested:

  • GETing the users endpoint behaves as expected when:
    1. the database is empty
    2. the database has an Individual;
  • GETing the user endpoint behaves as expected when:
    1. using an invalid mci_id
    2. using a valid mci_id;
  • POSTing to the users endpoint behaves as expected when:
    1. POSTing a new user with valid json
    2. POSTing an existing user
    3. POSTing with bad json
    4. POSTing with the
  • POSTing to the remove-pii endpoint behaves as expected when:
    1. providing an invalid mci_id
    2. providing a valid mci_id (and hence deleting PII)

@gregmundy - I am going to write additional tests for the "helper" functions in another PR.

@reginafcompton reginafcompton merged commit 78d98f4 into master Jul 3, 2019
@reginafcompton reginafcompton deleted the user-tests branch July 3, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant