[Iss298] momm seasonal adjusted #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiancaMorandi
added
function improvement
…ind-dev/brightwind into iss298_momm_seasonal_adj
| @@ -255,6 +256,9 @@ def _filter_out_months_based_on_coverage_threshold(var_series, monthly_coverage, | |||
| :param analysis_type: Text reporting the type of analysis to report in the warning messages | |||
| e.g 'mean of monthly mean' . | |||
| :type analysis_type: str | |||
| :param seasonal_adjustment: Optional, False by default. If True, returns text messages for seasonal adjusted | |||
There was a problem hiding this comment.
@BiancaMorandi seasonal_adjustment is not set to anything in the 'def'? But in the doc string you say it is default to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mommfunction to derive the seasonal adjusted mean of monthly mean speed if inputseasonal_adjustmentis True.mommThe seasonal adjusted mean of monthly mean is derived as for method below:
1) calculate monthly coverage
2) filter out any months with coverage lower than the input 'coverage_threshold'
3) derive the monthly mean for each calendar month (i.e. all January)
4) weighted average each monthly mean value based on the number of days in each month
(i.e. 31 days for January) - number of days for February are derived as average of actual days for the year
of the dataset. This to take into account leap years.