Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Moving the boot2docker init from setup to docker-osx-dev (all test pa… #36

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

Simperfit
Copy link
Contributor

…ssed)

@brikis98
Copy link
Owner

brikis98 commented Jun 3, 2015

Thanks for putting this together! Since integration tests are still blocked (see #7), I have to ask: did you run the local versions of setup.sh and docker-osx-dev to make sure things are still working?

@Simperfit
Copy link
Contributor Author

brikis98, Yes i've tested both, and i'm using the modified docker-osx-dev already.

brikis98 added a commit that referenced this pull request Jun 4, 2015
Moving the boot2docker init from setup to docker-osx-dev (all test pa…
@brikis98 brikis98 merged commit 40aff53 into brikis98:master Jun 4, 2015
@brikis98
Copy link
Owner

brikis98 commented Jun 4, 2015

Fantastic. Thank you!

@Simperfit
Copy link
Contributor Author

I've tried on my machine and in a new machine today.

We need the init_boot2docker in both it doest not write the /etc/hosts if the init is not in the setup, it does not install it

I will send a new PR with this.

@brikis98
Copy link
Owner

brikis98 commented Jun 4, 2015

Ah, you're right. The /etc/hosts entry depends on the boot2docker ip command. I guess for now, you can have the same functions in both scripts. I filed #39 to track the need to extract that duplicated functionality into a single, shared location.

@ain ain mentioned this pull request Jun 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants