Add rowHitAreaHeight and ignoreDropsOutside props
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 commits, one that adds
props.rowHitAreaHeight, another one that addsprops.ignoreDropsOutsideand a version bump commit.rowHitAreaHeight- gives the user control over the height or a row's hit area, when dragging items within it.By setting this to be the same as
rowHeightthe user can make the entire row a drop target, losing the top/bottom padding that is mostly useful for sorting the rows.I needed this to implement a more VSCode like behavior. Hope I didn't re-invent the wheel...
props.ignoreDropsOutside- when dropping a row over another component, React Arborist will still dispatch anonMoveevent, even though the file didn't drop inside the tree.By setting this to
true, the user can tell Arborist to ignore drops outside the tree.