Unique App Ids for Zui #2547
Merged
Unique App Ids for Zui #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
approved these changes
Sep 21, 2022
jameskerr
pushed a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like windows pays attention to the appId property in the electron builder config. It was set to "com.electron.brim" for Brim v30, Zui v1, and Zui-Insiders. This looks like the reason they were overwriting the folders.
Each one now has a unique app id.
It'd be good to check the auto-update behavior again before releasing Zui Stable. I expect it would be fine, but who knows.
Actually, since I've changed the appId for zui-insiders as well, we can see what happens when zui-insiders updates after this merges. If that works fine, then Zui will work fine as well.
fixes #2459