Fix argument parsing for inflate() #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inflate was given a numeric `window_size` argument, it was incorrectly falling into lzlib compatibility mode, because `lua_isstring` returns true for numbers as well. Changing to using `lua_type` checks for the actual data type (as in Lua `type()`) and not data convertibility.
|
Hi! Thank you for your work on lua-zlib! Please consider pushing a new release incorporating the latest fixes. I am adding native extraction of zip files to LuaRocks and the |
|
Thanks @hishamhm ! This was an oversight by me. |
|
The new version has been uploaded here: https://luarocks.org/modules/brimworks/lua-zlib 1.2-0 |
|
@brimworks Yay, thank you for the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inflate was given a numeric
window_sizeargument,it was incorrectly falling into lzlib compatibility mode,
because
lua_isstringreturns true for numbers as well.Changing to using
lua_typechecks for the actual datatype (as in Lua
type()) and not data convertibility.Fixes #40.