Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for Brioche.download() global function #75

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

kylewlacy
Copy link
Member

@kylewlacy kylewlacy commented Jul 19, 2024

Companion PR: brioche-dev/brioche#102

Part of brioche-dev/brioche#70

This PR adds an implementation for Brioche.download() on the Brioche global. Just like with the other functions for statics, the implementation is pretty simple and just uses the op_brioche_get_static op to do the heavy lifting

Here's an example snippet that could be used in the jq package:

const source = Brioche.download(
  "https://github.com/jqlang/jq/releases/download/jq-1.7.1/jq-1.7.1.tar.gz",
)
  .unarchive("tar", "gzip")
  .peel();

Left to do

  • Release new stable version of Brioche with support for Brioche.download()
  • Add version check to prevent usage on prior versions of Brioche

@kylewlacy kylewlacy marked this pull request as ready for review September 26, 2024 09:05
@kylewlacy kylewlacy merged commit 97ba592 into main Sep 26, 2024
3 checks passed
@kylewlacy kylewlacy deleted the locked-downloads branch September 26, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant