Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty particleblocks (and probably other blocks) break things #67

Closed
brisvag opened this issue Jan 6, 2021 · 2 comments
Closed

Empty particleblocks (and probably other blocks) break things #67

brisvag opened this issue Jan 6, 2021 · 2 comments

Comments

@brisvag
Copy link
Owner

brisvag commented Jan 6, 2021

We should handle gracefully empty blocks. Currently, particle depictors crash with an empty dataset, which can happen if you use ParticleBlock.if_properties().

It's probably a problem elsewhere.

@alisterburt
Copy link
Collaborator

alisterburt commented Jan 6, 2021 via email

@brisvag
Copy link
Owner Author

brisvag commented May 25, 2021

This was addressed (hopefully) in #69. If anything comes up, we can reopen.

@brisvag brisvag closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants