-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive PR, datamodel change. #68
Conversation
…pecs. Attempts at method signature wrappers
Codecov Report
@@ Coverage Diff @@
## develop #68 +/- ##
===========================================
+ Coverage 68.51% 70.06% +1.54%
===========================================
Files 85 101 +16
Lines 1639 1974 +335
===========================================
+ Hits 1123 1383 +260
- Misses 516 591 +75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - seems like working with datasets will be easier with this architecture! Few tiny questions but nothing blocking, happy for you to merge if you're happy!
…and re-added nameguessing
This PR started as a rework of some classification function, and soon it was clear that many things in the datamodel and project structure needed fixing. I changed a lot of stuff, but here's a (probably incomplete) writeup:
DataSet
at its core.DataBlock
s are now directly contained in it, and have themselves a reference to what "volume" (previouslyDataCrate
object) they belong to. This greatly simplify looping and such, since we're not working with an actual nested structure.DispatchList
functionality is still present, but only when needed (not directly on the dataset itself, but for example when callingDataSet.particles
)Tests work but things may have broken where tests don't cover... will need some more time to figure it out!