Fixed P2P_discovery sockets not being released on stop #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there was reference to 'udp_broadcast' which wasn't declared anywhere, preventing :close() from working :: corrected - stopping the listener then starting it a second time failed since the socket hadn't been closed at all :: fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. There's a problem with p2p_discovery.lua in that, when
.stopgets called on an active listener, the socket is never closed. This blocks.listenfrom working a second time.Similarly, line 70 attempts
udp_broadcast:close()butudp_broadcastisn't defined.