Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the use of "Mark Text" #54

Merged
merged 8 commits into from
Jun 13, 2019

Conversation

Jerakin
Copy link
Contributor

@Jerakin Jerakin commented Jun 12, 2019

I frequently find myself that I want to handle marked text as already committed, this gives add a option to do that. Meaning if you are on a device and deselect the input field your text will not disappear.

@@ -5,9 +5,9 @@ function init(self)

dirtylarry.checkbox("checkbox").set_checked(true)
dirtylarry.radio("radio2").set_selected(true)
dirtylarry.input("input", gui.KEYBOARD_TYPE_DEFAULT, nil, nil, { empty_text = "EMPTY, MAX 8 CHARS" })
dirtylarry.input("input", gui.KEYBOARD_TYPE_DEFAULT, nil, nil, { empty_text = "EMPTY, MAX 8 CHARS" }).set_use_mark_text(false)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the config table instead of adding a new function. Like this:

{ empty_text = "EMPTY, MAX 8 CHARS", use_marked_text = false }

Copy link
Owner

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@britzl britzl merged commit 64c522f into britzl:master Jun 13, 2019
@Jerakin Jerakin deleted the mark_text_option branch June 17, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants