finish transaction when layout changes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
britzl
requested changes
Jun 9, 2018
monarch/transitions/gui.lua
Outdated
| } | ||
| end | ||
|
|
||
| local function finish_transaction(transition) |
There was a problem hiding this comment.
It should be finish_transition() not finish_transaction()?
| @@ -139,6 +145,9 @@ function M.create(node) | |||
| -- were transitioned out | |||
| if current_transition then | |||
| current_transition.fn(node, initial_data, current_transition.easing, 0, 0) | |||
| if current_transition.in_progress then | |||
There was a problem hiding this comment.
So we call the transition function again on the line above to immediately finish it (duration = 0), but what if there already is a transition going? Won't the transition that was playing while the layout changed continue to play? Or does a call to gui.animate() override an existing animation? I think the default transitions need to do a gui.cancel_animation() as well or?
There was a problem hiding this comment.
Default transition will be override by a new transition (with 0 duration) but without Done event because of nil callback of the new transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If layout changes when transaction in progress we have to finish current transaction