Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequential loading flag #62

Merged
merged 1 commit into from
May 20, 2020
Merged

Add sequential loading flag #62

merged 1 commit into from
May 20, 2020

Conversation

dapetcu21
Copy link
Contributor

Sometimes, you might want to wait for the previous scene to fully transition out before transitioning the new scene in (a fade-to-black transition is such an example). This also has the benefit of not having both scenes in memory at the same time and masking the few slow loading frames of a scene in-between the two scenes (on a black screen).

This is exactly how we did scene transitions in Interrogation (though we rolled our own scene manager there).

This was already happening when transitioning to the same scene ID, so I just added a flag to have that behaviour on-demand.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files           4        4           
  Lines         838      838           
=======================================
  Hits          698      698           
  Misses        140      140           
Impacted Files Coverage Δ
monarch/monarch.lua 86.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909ada9...cce9970. Read the comment docs.

Copy link
Owner

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little addition. Thanks!

@britzl britzl merged commit c7fb2ba into britzl:master May 20, 2020
@dapetcu21 dapetcu21 deleted the sequential branch May 21, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants