Added wall slide support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…behavior allows to modify signicifantly the velocity during wall jump using left and right functions. New config key const_wall_jump is by default set to false, so it doesn't change the legacy, but when set to true by user, it blocks possibility to alter a jump after bouncing from a wall. Added new state - wall_jump and thus added a function to get that information from platypus.
…tion - is_wall_jumping()
…n now handle wall slide with a mutable wall_slide_gravity, which simulates sliding slowly down a wall. It notifies game object about starting wall slide and user can check if it is_wall_sliding(). Added this possibility to the example project. Fixed collision rays in example's config. Added abort_wall_slide() when control keys are released. Updated readme with new functionality.
britzl
requested changes
Sep 11, 2019
| @@ -108,6 +117,8 @@ Platypus will send messages for certain state changes so that scripts can react, | |||
| print("Doing a double jump!") | |||
| elseif message_id == platypus.JUMP then | |||
| print("Jumping!") | |||
| elseif message_id == platypus.WALL_SLIDE then | |||
platypus/platypus.lua
Outdated
| -- apply wall slide gravity | ||
| if state.current.wall_slide then | ||
| platypus.velocity.y = platypus.velocity.y + platypus.wall_slide_gravity * dt | ||
|
|
platypus/platypus.lua
Outdated
| @@ -324,6 +346,11 @@ function M.create(config) | |||
| elseif state.current.wall_contact and platypus.allow_wall_jump then | |||
| state.current.wall_jump = true | |||
| state.previous.wall_jump = true | |||
| -- abort wall sliding when jumping from wall | |||
There was a problem hiding this comment.
Maybe call platypus.abort_wall slide() instead? Or skip the conditional check and set current+previous wall_slide to false
README.md
Outdated
| @@ -79,6 +79,15 @@ Use `platypus.jump()` to perform a jump and `platypus.abort_jump()` to reduce th | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| ## Double jump, wall jump and wall slide | |||
| Platypus supports double jumps when config.allow_double_jump is set to true. Then, it occurs automatically, when used jump() while already jumped up. | |||
There was a problem hiding this comment.
Change second sentence to "A double jump is performed automatically when a second jump is done before and up until reaching the apex of the first jump. It is not possible to performa a double jump when falling"
README.md
Outdated
| ## Double jump, wall jump and wall slide | ||
| Platypus supports double jumps when config.allow_double_jump is set to true. Then, it occurs automatically, when used jump() while already jumped up. | ||
|
|
||
| Platypus supports wall jumps when config.allow_wall_jump is set to true. Then, it occurs automatically, when used jump() while having a wall_contact. |
There was a problem hiding this comment.
Change second sentence. "A wall jump is performed automatically when jumping while having wall contact while falling or wall sliding. The wall jump pushes the player out from the wall in question."
README.md
Outdated
| Platypus supports wall jumps when config.allow_wall_jump is set to true. Then, it occurs automatically, when used jump() while having a wall_contact. | ||
| Normally, user can alter your movement right after bounced from a wall, but when you set config.const_wall_jump - the bounce will be always the same and user won't be able to alter it. | ||
|
|
||
| Platypus supports wall slide when config.allow_wall_slide is set to true. Then, it occurs automatically, when pushing toward a wall, while falling down. Platypus offers also to abort_wall_slide(), for example, when the control key is released, so user is no longer pushing toward the wall. |
There was a problem hiding this comment.
Change second sentence. "A wall slide will be performed automatically when the player has wall contact while falling and moving (using platypus.left() or platypus.right()) in the direction of the wall."
|
Thanks for the review! I'll push a commit probably this evening ;) |
…ide() when wall jumping.
britzl
approved these changes
Sep 13, 2019
britzl
requested changes
Sep 13, 2019
britzl
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wall slide support.
Platypus, when
config.allow_wall_slideistrue, can now handle wall slide with a mutableconfig.wall_slide_gravity, which simulates sliding slowly down a wall. It notifies game object about starting wall slide with a messageplatypus.WALL_SLIDEand user can check if itis_wall_sliding(). Added this possibility to the example project. Fixed collision rays in example's config. Addedabort_wall_slide()when control keys are released. Updated readme with new functionality informations and general double and wall jumps and wall slide.