Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to existent HTML demos #73

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Minor changes to existent HTML demos #73

merged 5 commits into from
Dec 6, 2021

Conversation

brmighell
Copy link
Owner

Also made sure no demo was using the same div

@coveralls
Copy link

coveralls commented Dec 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1542853858

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.609%
Totals Coverage Status
Change from base Build 1542600950: 0.0%
Covered Lines: 277
Relevant Lines: 288
💛 - Coveralls

artoonie
artoonie approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@artoonie artoonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to run python3 docs/readme-generator.py to update the two autogenerated files & get the tests to pass

@fotakis08 fotakis08 self-requested a review December 6, 2021 02:29
@brmighell brmighell merged commit 0582e45 into main Dec 6, 2021
@brmighell brmighell deleted the update-html-demos branch December 6, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fotakis08 fotakis08 fotakis08 approved these changes

@artoonie artoonie artoonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brmighell @coveralls @artoonie @fotakis08